Added new section in product features to handle common UI features #19916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Any features that are common thru out the UI, are accessible from multiple screens in UI can live in this section. Example of such feature is Advanced search that is available thru out the UI and cannot be added as an individual feature under any one section. - New feature added in this PR addresses an issue where in the past only Super Admin user and Admin user could add Global filters for everyone to see, but now as we have different types of Admin users it is better to have this as a product feature. Without this fix currently anyone can add global filters in UI. This PR addresses issues mention in ManageIQ/manageiq-ui-classic#6253
|
Checked commit h-kataria@2b21af0 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
mzazrivec
approved these changes
Mar 9, 2020
agrare
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues mention in ManageIQ/manageiq-ui-classic#6253
before
after
UI changes are in ManageIQ/manageiq-ui-classic#6723